Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test with java 21 #2002

Open
wants to merge 59 commits into
base: develop
Choose a base branch
from
Open

test with java 21 #2002

wants to merge 59 commits into from

Conversation

denis-yuen
Copy link
Member

@denis-yuen denis-yuen commented Aug 8, 2024 •
edited
Loading

Description
Run tests and webservice in a Java 21 environment in anticipation of webservice and dockstore-components switching to Java 21.

Review Instructions
Build should just function just like it did before this change

Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-6612

Security
None

  • Check that your code compiles by running npm run build
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • If this is the first time you're submitting a PR or even if you just need a refresher, consider reviewing our style guide
  • Do not bypass Angular sanitization (bypassSecurityTrustHtml, etc.), or justify why you need to do so
  • If displaying markdown, use the markdown-wrapper component, which does extra sanitization
  • Do not use cookies, although this may change in the future
  • Run npm audit and ensure you are not introducing new vulnerabilities
  • Do due diligence on new 3rd party libraries, checking for CVEs
  • Don't allow user-uploaded images to be served from the Dockstore domain
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.
  • Check whether this PR disables tests. If it legitimately needs to disable a test, create a new ticket to re-enable it in a specific milestone.

@denis-yuen denis-yuen self-assigned this Aug 8, 2024
@denis-yuen denis-yuen changed the title test this test with java 21 Aug 8, 2024
@denis-yuen
Copy link
Member Author

accessibility test seems like false positive and not a java thing

@denis-yuen denis-yuen requested review from coverbeck, kathy-t, a team and hyunnaye and removed request for a team August 8, 2024 18:00
@denis-yuen denis-yuen marked this pull request as ready for review August 8, 2024 18:00
@denis-yuen
Copy link
Member Author

Oops, needs longer look

@codecov Codecov
Copy link

codecov bot commented Aug 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.78%. Comparing base (1d2ac11) to head (56f0639).
Report is 2 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #2002   +/-   ##
========================================
  Coverage    41.78%   41.78%           
========================================
  Files          390      390           
  Lines        12321    12321           
  Branches      2946     2946           
========================================
  Hits          5148     5148           
  Misses        4870     4870           
  Partials      2303     2303

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@denis-yuen
Copy link
Member Author

Something dies in Java 19. https://gist.github.com/denis-yuen/b6af4e9ffcdf43f227a24ed0dbb78e77
Could be the Ubuntu 22, or something super minor with wget, curl, node, maven?

@denis-yuen
Copy link
Member Author

denis-yuen commented Aug 14, 2024 •
edited
Loading

Note for self:
Java 18 is using Nginx 1.18.0
Java 19 with a fixed signing key is using Nginx 1.18.0

1.18.0-0ubuntu1.5 vs 1.18.0-6ubuntu14.4 though

@hyunnaye hyunnaye assigned hyunnaye and unassigned denis-yuen Mar 6, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hyunnaye hyunnaye

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@denis-yuen @hyunnaye